Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Iago Toral
Thanks Ken, this does make debugging NIR code a bit easier :) Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Wed, 2015-06-10 at 02:39 -0700, Kenneth Graunke wrote: This makes the SSA definitions use sequential numbers (0, 1, 2, ...) instead of seemingly random ones. There's not much

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Connor Abbott
On Thu, Jun 11, 2015 at 8:27 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Thu, Jun 11, 2015 at 8:12 AM, Connor Abbott cwabbo...@gmail.com wrote: The one thing this will hurt is that diff'ing shaders from before and after an optimization becomes harder, since just printing the shader will

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Jason Ekstrand
On Thu, Jun 11, 2015 at 8:12 AM, Connor Abbott cwabbo...@gmail.com wrote: The one thing this will hurt is that diff'ing shaders from before and after an optimization becomes harder, since just printing the shader will re-order the numbers and add spurious changes. If we want to make the result

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Connor Abbott
The one thing this will hurt is that diff'ing shaders from before and after an optimization becomes harder, since just printing the shader will re-order the numbers and add spurious changes. If we want to make the result of doing INTEL_DEBUG=fs more reasonable, we could just do it at the end of

[Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-10 Thread Kenneth Graunke
This makes the SSA definitions use sequential numbers (0, 1, 2, ...) instead of seemingly random ones. There's not much point normally, but it makes debug output much easier to read. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_nir.c | 6 ++ 1 file