Re: [Mesa-dev] [PATCH] i965: Return NONE from brw_swap_cmod on unknown input.

2014-08-12 Thread Connor Abbott
On Mon, Aug 11, 2014 at 11:22 AM, Matt Turner matts...@gmail.com wrote: Comparing ~0u with a packed enum (i.e., 1 byte) always evaluates to false. Shouldn't gcc warn about this? Reported-by: Connor Abbott cwabbo...@gmail.com --- src/mesa/drivers/dri/i965/brw_eu.c | 2 +-

[Mesa-dev] [PATCH] i965: Return NONE from brw_swap_cmod on unknown input.

2014-08-11 Thread Matt Turner
Comparing ~0u with a packed enum (i.e., 1 byte) always evaluates to false. Shouldn't gcc warn about this? Reported-by: Connor Abbott cwabbo...@gmail.com --- src/mesa/drivers/dri/i965/brw_eu.c | 2 +- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +-

Re: [Mesa-dev] [PATCH] i965: Return NONE from brw_swap_cmod on unknown input.

2014-08-11 Thread Kenneth Graunke
On Monday, August 11, 2014 11:22:22 AM Matt Turner wrote: Comparing ~0u with a packed enum (i.e., 1 byte) always evaluates to false. Shouldn't gcc warn about this? Reported-by: Connor Abbott cwabbo...@gmail.com Looks good to me. Reviewed-by: Kenneth Graunke kenn...@whitecape.org