Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-05-01 Thread Chad Versace
g > > Subject: Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double > > close issue > > > > On 28 April 2017 at 17:18, Chad Versace > > wrote: > > > Emil, how about one of us appends your extended commit message to > > > Randy's,

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-29 Thread Xu, Randy
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Saturday, April 29, 2017 8:36 PM > To: Chad Versace ; Emil Velikov > ; Xu, Randy ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] i965: Solve Android native fe

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-29 Thread Emil Velikov
On 28 April 2017 at 17:18, Chad Versace wrote: > On Thu 27 Apr 2017, Emil Velikov wrote: >> On 27 April 2017 at 12:14, Xu, Randy wrote: >> > Hi, Chad >> > >> > Please review this patch, we need it to solve some instability issues > > Randy and Tapani, could you provide a few dEQP test names that

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-28 Thread Xu, Randy
> -Original Message- > From: Chad Versace [mailto:chadvers...@chromium.org] > Sent: Saturday, April 29, 2017 12:19 AM > To: Emil Velikov > Cc: Xu, Randy ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double > cl

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-28 Thread Chad Versace
On Thu 27 Apr 2017, Emil Velikov wrote: > On 27 April 2017 at 12:14, Xu, Randy wrote: > > Hi, Chad > > > > Please review this patch, we need it to solve some instability issues Randy and Tapani, could you provide a few dEQP test names that this patch fixes? I'd like to mention at least one EGL an

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-27 Thread Emil Velikov
On 27 April 2017 at 12:14, Xu, Randy wrote: > Hi, Chad > > Please review this patch, we need it to solve some instability issues > The patch is correct, although the commit message can be improved upon. Read through the following example and consider the alternative solution mentioned within. The

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-27 Thread Xu, Randy
Hi, Chad Please review this patch, we need it to solve some instability issues Thanks, Randy > -Original Message- > From: Palli, Tapani > Sent: Thursday, April 20, 2017 2:58 PM > To: Xu, Randy ; mesa-dev@lists.freedesktop.org > Cc: Chad Versace > Subject: Re: [PATCH] i965: Solve Andro

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-19 Thread Tapani Pälli
Ping Chad On 04/20/2017 08:20 AM, Xu, Randy wrote: Any comments to this patch? Thanks, Randy -Original Message- From: Xu, Randy Sent: Tuesday, April 18, 2017 2:27 PM To: mesa-dev@lists.freedesktop.org Cc: Palli, Tapani ; Xu, Randy Subject: [PATCH] i965: Solve Android native fence fd

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-19 Thread Xu, Randy
Any comments to this patch? Thanks, Randy > -Original Message- > From: Xu, Randy > Sent: Tuesday, April 18, 2017 2:27 PM > To: mesa-dev@lists.freedesktop.org > Cc: Palli, Tapani ; Xu, Randy > Subject: [PATCH] i965: Solve Android native fence fd double close issue > > The Android native

[Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-17 Thread Randy Xu
The Android native fence in i965 driver has two fd, one is from App and stored in _EGLSync.SyncFd; Another one brw_fence->sync_fd should be the dup of the first one, not direct copy. These two fds are closed in dri2_egl_unref_sync in sequence. Test: Run Vulkan and GLES stress test and no crash. S