[Mesa-dev] [PATCH] i965: Store uniform constant values in a gl_constant_value instead of float

2014-08-12 Thread Neil Roberts
Hi, Here is a replacement patch for the one to use memcpy when copying uniform values into the batch buffer here: http://lists.freedesktop.org/archives/mesa-dev/2014-August/065179.html Eric Anholt suggested instead of using memcpy we should change the type of the pointer to uint32_t. I started

Re: [Mesa-dev] [PATCH] i965: Store uniform constant values in a gl_constant_value instead of float

2014-08-12 Thread Roland Scheidegger
This looks good to me. However I'm wondering if it would be better to use a generic float/int union. I guess though these values actually really are gl_constant_value type (as they come as gl params) so this looks good. Roland Am 12.08.2014 20:04, schrieb Neil Roberts: Hi, Here is a

Re: [Mesa-dev] [PATCH] i965: Store uniform constant values in a gl_constant_value instead of float

2014-08-12 Thread Kenneth Graunke
On Tuesday, August 12, 2014 07:04:23 PM Neil Roberts wrote: Hi, Here is a replacement patch for the one to use memcpy when copying uniform values into the batch buffer here: http://lists.freedesktop.org/archives/mesa-dev/2014-August/065179.html Eric Anholt suggested instead of using