Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-28 Thread Eero Tamminen
Hi, On 20.03.2018 19:06, Dylan Baker wrote: Quoting Emil Velikov (2018-03-20 09:29:00) [snip] gens = [] for xml_file in args.xml_files: @@ -617,7 +610,7 @@ def main(): """)) -c("#include \"" + os.path.basename(args.header) + "\"") +c("#include \"" +

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 17:06, Lionel Landwerlin wrote: > On 20/03/18 16:29, Emil Velikov wrote: >> >> From: Emil Velikov >> >> As of earlier commit, the --header was made a hard requirement when >> using --code. >> >> Hence - annotate both

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 16:29, Emil Velikov wrote: From: Emil Velikov As of earlier commit, the --header was made a hard requirement when using --code. Hence - annotate both as required and drop a few no longer needed checks. Fixes: 035cc7a12dc0 ("i965: perf: reduce i965

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Dylan Baker
Quoting Emil Velikov (2018-03-20 09:29:00) [snip] > gens = [] > for xml_file in args.xml_files: > @@ -617,7 +610,7 @@ def main(): > > """)) > > -c("#include \"" + os.path.basename(args.header) + "\"") > +c("#include \"" + os.path.basename(header_file) + "\"") You're

[Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Emil Velikov
From: Emil Velikov As of earlier commit, the --header was made a hard requirement when using --code. Hence - annotate both as required and drop a few no longer needed checks. Fixes: 035cc7a12dc0 ("i965: perf: reduce i965 binary size") Cc: Lionel Landwerlin