Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Jason Ekstrand
On Wed, Nov 1, 2017 at 9:24 AM, Tapani Pälli wrote: > > > On 11/01/2017 04:55 PM, Jason Ekstrand wrote: > >> On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand > > wrote: >> >> On Fri, Oct 27, 2017 at 5:55 AM, Tapani

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Tapani Pälli
On 11/01/2017 04:55 PM, Jason Ekstrand wrote: On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand > wrote: On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli > wrote: Patch uses

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Tapani Pälli
On 11/01/2017 12:59 PM, Andres Gomez wrote: Tapani, this patch landed with the "mesa-sta...@lists.freedesktop.org" tag without specifying branch. However, it addresses a fix for 8d90e28839, which didn't land in 17.2 so I'm skipping this patch for that queue. I hope this is OK with you. Let

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Jason Ekstrand
On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli > wrote: > >> Patch uses mem_ctx for allocation to ensure param array gets freed >> later, in blorp clear case this happens in

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli wrote: > Patch uses mem_ctx for allocation to ensure param array gets freed > later, in blorp clear case this happens in blorp_params_get_clear_kernel. > > ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-11-01 Thread Andres Gomez
Tapani, this patch landed with the "mesa-sta...@lists.freedesktop.org" tag without specifying branch. However, it addresses a fix for 8d90e28839, which didn't land in 17.2 so I'm skipping this patch for that queue. I hope this is OK with you. Let me know otherwise. On Fri, 2017-10-27 at 15:55

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 14:53, Lionel Landwerlin wrote: > On 27/10/17 14:46, Emil Velikov wrote: >> >> On 27 October 2017 at 13:55, Tapani Pälli wrote: >>> >>> Patch uses mem_ctx for allocation to ensure param array gets freed >>> later, in

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Lionel Landwerlin
On 27/10/17 14:46, Emil Velikov wrote: On 27 October 2017 at 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 13:55, Tapani Pälli wrote: > Patch uses mem_ctx for allocation to ensure param array gets freed > later, in blorp clear case this happens in blorp_params_get_clear_kernel. > > ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/10/17 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost

[Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Tapani Pälli
Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193 ==6164==at 0x4C2EB6B: malloc (vg_replace_malloc.c:299) ==6164==by