Re: [Mesa-dev] [PATCH] intel/compiler: fix return statement warning in brw_regs_negative_equal()

2018-03-29 Thread Ian Romanick
I have a theory about this warning... I'll either have a patch or an R-b today. On 03/28/2018 06:48 PM, Brian Paul wrote: > Silence a gcc warning about missing return value in non-void function. > For some reason, gcc 5.4.0 (at least) can't deduce that all else/if > cases return a value. > --- >

Re: [Mesa-dev] [PATCH] intel/compiler: fix return statement warning in brw_regs_negative_equal()

2018-03-29 Thread Brian Paul
On 03/29/2018 03:49 AM, Emil Velikov wrote: Hi Brian, On 29 March 2018 at 02:48, Brian Paul wrote: Silence a gcc warning about missing return value in non-void function. For some reason, gcc 5.4.0 (at least) can't deduce that all else/if cases return a value. A small

Re: [Mesa-dev] [PATCH] intel/compiler: fix return statement warning in brw_regs_negative_equal()

2018-03-29 Thread Emil Velikov
Hi Brian, On 29 March 2018 at 02:48, Brian Paul wrote: > Silence a gcc warning about missing return value in non-void function. > For some reason, gcc 5.4.0 (at least) can't deduce that all else/if > cases return a value. A small brain dump: Guessing that's because of the

[Mesa-dev] [PATCH] intel/compiler: fix return statement warning in brw_regs_negative_equal()

2018-03-28 Thread Brian Paul
Silence a gcc warning about missing return value in non-void function. For some reason, gcc 5.4.0 (at least) can't deduce that all else/if cases return a value. --- src/intel/compiler/brw_reg.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_reg.h