Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
: <20181026140354.gd3...@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length. On Fri, Oct 26, 2018 at 02:24:19PM +0100, Lionel Landwerlin wrote: Overall I agree this probabl

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
> > Message-ID: <20181026140354.gd3...@intel.com> > > User-Agent: Mutt/1.9.4 (2018-02-28) > > Subject: Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and > > 'bias' fields for packet length. > > > > On Fri, Oct 26, 2018 at 0

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
intel/decoder: Use 'DWord Length' and 'bias' fields for packet length. On Fri, Oct 26, 2018 at 02:24:19PM +0100, Lionel Landwerlin wrote: Overall I agree this probably what we should do rather than this long special case switch in gen_group_get_length(). There are some other

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
- Forwarded message from Toni Lönnberg - Date: Fri, 26 Oct 2018 17:03:54 +0300 From: Toni Lönnberg To: Lionel Landwerlin Message-ID: <20181026140354.gd3...@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
Overall I agree this probably what we should do rather than this long special case switch in gen_group_get_length(). I have one suggestion below. On 26/10/2018 14:07, Toni Lönnberg wrote: Use the 'DWord Length' and 'bias' fields from the instruction definition to parse the packet length from th

[Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
Use the 'DWord Length' and 'bias' fields from the instruction definition to parse the packet length from the command stream when possible. The hardcoded mechanism is used whenever an instruction doesn't have this field. --- src/intel/common/gen_decoder.c | 16 ++-- src/intel/common/gen