Re: [Mesa-dev] [PATCH] intel: tools: Add handling for video pipe

2018-10-29 Thread Toni Lönnberg
Hadn't noticed your patch series before, sorry for that. I'd like to get rid of the magic numbers for the registers and have the code use the definitions instead for sure. Can you push this one in? On Mon, Oct 29, 2018 at 03:36:12PM +, Lionel Landwerlin wrote: > Looks correct to me. Maybe

Re: [Mesa-dev] [PATCH] intel: tools: Add handling for video pipe

2018-10-29 Thread Lionel Landwerlin
Looks correct to me. Maybe you'll find something useful from this series : https://patchwork.freedesktop.org/series/50135/ Reviewed-by: Lionel Landwerlin On 29/10/2018 14:05, Toni Lönnberg wrote: Preliminary work for adding handling of different pipes to gen_decoder. We need to be able to

[Mesa-dev] [PATCH] intel: tools: Add handling for video pipe

2018-10-29 Thread Toni Lönnberg
Preliminary work for adding handling of different pipes to gen_decoder. We need to be able to distinguish between different pipes in order to decode the packets correctly due to opcode re-use. --- src/intel/tools/aub_read.c | 26 ++ src/intel/tools/aub_read.h | 5 - 2