Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Rafael Antognolli
On Mon, Jul 30, 2018 at 04:28:37PM +0100, Lionel Landwerlin wrote: > Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > of the context image. Cool, I see you are also adding a couple missing commands and noops into the gen10+ contexts. Reviewed-by: Rafael Antognolli > We

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
On 30/07/18 17:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 17:08:47) On 30/07/18 16:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 16:28:37) Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. Hmm, do you think we

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-30 17:08:47) > On 30/07/18 16:45, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-07-30 16:28:37) > >> Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > >> of the context image. > > Hmm, do you think we should perhaps include the BBE

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
On 30/07/18 16:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 16:28:37) Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. Hmm, do you think we should perhaps include the BBE in the protocontext we create in the kernel? -Chris I can't

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-30 16:28:37) > Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > of the context image. Hmm, do you think we should perhaps include the BBE in the protocontext we create in the kernel? -Chris ___

[Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. We select the largest size for the context image regardless of the generation. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_write.c | 216 +---