Re: [Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

2012-03-30 Thread Pekka Paalanen
On Thu, 29 Mar 2012 14:16:10 -0700 Ian Romanick i...@freedesktop.org wrote: On 03/29/2012 10:41 AM, Kenneth Graunke wrote: On 03/28/2012 11:43 PM, Vinson Lee wrote: Fixes a Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson

[Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

2012-03-29 Thread Vinson Lee
Fixes a Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/glsl/link_uniforms.cpp |1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index

Re: [Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

2012-03-29 Thread Eric Anholt
On Wed, 28 Mar 2012 23:43:30 -0700, Vinson Lee v...@freedesktop.org wrote: Fixes a Coverity resource leak defect. I'm betting coverity is pointing out a case where this is sometimes leaked, but not every time, while you're freeing it every time. pgpmiJpUky7fj.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

2012-03-29 Thread Kenneth Graunke
On 03/28/2012 11:43 PM, Vinson Lee wrote: Fixes a Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Leev...@freedesktop.org --- src/glsl/link_uniforms.cpp |1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/link_uniforms.cpp

Re: [Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

2012-03-29 Thread Ian Romanick
On 03/29/2012 10:41 AM, Kenneth Graunke wrote: On 03/28/2012 11:43 PM, Vinson Lee wrote: Fixes a Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Leev...@freedesktop.org --- src/glsl/link_uniforms.cpp | 1 + 1 file changed, 1 insertion(+) diff