Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-07 Thread
On Tue, Jun 7, 2016 at 2:43 AM, Timothy Arceri wrote: > On Mon, 2016-06-06 at 12:33 +0200, ⚛ wrote: >> On Mon, Jun 6, 2016 at 12:29 PM, Timothy Arceri >> wrote: >> > >> > I'm pretty sure someone told you this already. But you need to >> > remove >> > that symbol and just use your name. Note the s

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-07 Thread
On Mon, Jun 6, 2016 at 1:12 PM, Emil Velikov wrote: > On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com> wrote: >> LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because >> src/mapi uses unusual mixing of C code and assembly code. The issue >> may be present in case of G

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Timothy Arceri
On Mon, 2016-06-06 at 12:33 +0200, ⚛ wrote: > On Mon, Jun 6, 2016 at 12:29 PM, Timothy Arceri > wrote: > > > > I'm pretty sure someone told you this already. But you need to > > remove > > that symbol and just use your name. Note the symbol also seems to > > be > > casing your name to be removed

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I only have /var/log/portage/elog/ the file(s) you specified don't exist on my system On Mon, 6 Jun 2016 at 21:13 ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > > > I'm running Gentoo too, it didn't take significantly longer to compile > GCC 6.1 tha

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > I'm running Gentoo too, it didn't take significantly longer to compile GCC > 6.1 than any other version of GCC > > I use portage to compile mesa Ok. What is the output of a command like: $ ls --sort=time /var/log/portage/media-libs:mesa-*.

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I'm running Gentoo too, it didn't take significantly longer to compile GCC 6.1 than any other version of GCC I use portage to compile mesa On Mon, 6 Jun 2016, 5:58 p.m. ⚛, <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > > > This doesn't seem to affect

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > This doesn't seem to affect me using GCC 6.1 and gold I don't have GCC 6.1 installed at the moment, and it takes quite long to install it on Gentoo. Can you please send me the output of the following command? $ cd mesa/src/mapi $ make clea

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Emil Velikov
On 6 June 2016 at 13:01, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 1:12 PM, Emil Velikov wrote: >> >> Hi Jan, >> >> Fwiw I fully agree on your point on outstanding patches. >> >> Now about this patch itself. >> >> On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com>

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
This doesn't seem to affect me using GCC 6.1 and gold On Thu, 2 Jun 2016, 6:42 p.m. Jan Ziak (⚛), <0xe2.0x9a.0...@gmail.com> wrote: > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because > src/mapi uses unusual mixing of C code and assembly code. The issue > may be present in case

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 1:12 PM, Emil Velikov wrote: > > Hi Jan, > > Fwiw I fully agree on your point on outstanding patches. > > Now about this patch itself. > > On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com> wrote: > > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Emil Velikov
Hi Jan, Fwiw I fully agree on your point on outstanding patches. Now about this patch itself. On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com> wrote: > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because > src/mapi uses unusual mixing of C code and assembly code.

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 12:29 PM, Timothy Arceri wrote: > I'm pretty sure someone told you this already. But you need to remove > that symbol and just use your name. Note the symbol also seems to be > casing your name to be removed in patchwork. There's no causal relationship between a name and su

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Timothy Arceri
I'm pretty sure someone told you this already. But you need to remove that symbol and just use your name. Note the symbol also seems to be casing your name to be removed in patchwork. On Mon, 2016-06-06 at 12:11 +0200, ⚛ wrote: > Hello > > I would like to keep the number of lines displayed at > h

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
Hello I would like to keep the number of lines displayed at http://patchwork.freedesktop.org/project/mesa/patches/?submitter=15850 to a low number. 0 is the best, 1 or 2 is meh...ok, 3+ is too much. Seeing 0 lines allows me to move on and start working on the next patch. From my viewpoint, the i

[Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-02 Thread
LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because src/mapi uses unusual mixing of C code and assembly code. The issue may be present in case of GCC 6.1 as well. This is a Mesa bug rather than a compiler bug (although in an ideal world the compilation with -flto should fail if and