Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Matt Turner
On Mon, Sep 1, 2014 at 4:22 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com Coverity reported this, and I think this is the right solution, since cache-items is struct cache_item ** not struct cache_item *, we also realloc it using struct cache_item * at some

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Carl Worth
Matt Turner matts...@gmail.com writes: git blaming that turns up a sloppy search and replace commit that replaced _mesa_calloc(x) (taking only one argument) with calloc(1, x), even when x was a multiplication expression. Thanks for chasing that down. If someone wants to fix these up: git

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: And here's another that isn't the same pattern, (no 1, so not part of the same search/replace issue), but potentially still worth looking at. Here, there are three things being multiplied. I haven't looked at ... src/mesa/tnl/t_vertex.c: vtx-vertex_buf

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-02 Thread Tapani Pälli
Yep, it should be allocating just the pointers. Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 09/02/2014 02:22 AM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com Coverity reported this, and I think this is the right solution, since cache-items is struct cache_item ** not

[Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Coverity reported this, and I think this is the right solution, since cache-items is struct cache_item ** not struct cache_item *, we also realloc it using struct cache_item * at some point. Signed-off-by: Dave Airlie airl...@redhat.com ---