Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-07-08 Thread Kenneth Graunke
On Saturday, July 8, 2017 7:01:30 AM PDT Andres Gomez wrote: > Kenneth, worth cherry-picking for -stable? I wouldn't - this patch just imposes additional restrictions, making things we used to support illegal. That means it carries a risk of breaking existing applications, and really only benefit

Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-07-08 Thread Andres Gomez
Kenneth, worth cherry-picking for -stable? On Wed, 2017-06-28 at 02:44 -0700, Kenneth Graunke wrote: > This patch makes glCopyImageSubData require mipmap completeness when the > texture object's built-in sampler object has a mipmapping MinFilter. > This is apparently the de facto behavior and mand

Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-06-28 Thread Roland Scheidegger
At least the conclusion is semi-sane... Reviewed-by: Roland Scheidegger Am 28.06.2017 um 11:44 schrieb Kenneth Graunke: > This patch makes glCopyImageSubData require mipmap completeness when the > texture object's built-in sampler object has a mipmapping MinFilter. > This is apparently the de fa

[Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-06-28 Thread Kenneth Graunke
This patch makes glCopyImageSubData require mipmap completeness when the texture object's built-in sampler object has a mipmapping MinFilter. This is apparently the de facto behavior and mandated by Android's CTS. One exception is that we ignore format based completeness rules (specifically intege