Re: [Mesa-dev] [PATCH] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-02 Thread Tapani Pälli
On 10/02/2015 07:46 PM, Ilia Mirkin wrote: On Mon, Sep 28, 2015 at 5:12 AM, Tapani Pälli wrote: Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resource list. We need to take this to account with all functions dealing with active input attributes. Patch

Re: [Mesa-dev] [PATCH] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-02 Thread Ilia Mirkin
On Mon, Sep 28, 2015 at 5:12 AM, Tapani Pälli wrote: > Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings > as part of program resource list. We need to take this to account with > all functions dealing with active input attributes. > > Patch fixes the issue by adding additional

Re: [Mesa-dev] [PATCH] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-01 Thread Tapani Pälli
Ping, could someone ack/review this? If not, I will revert the patches that caused this for now and figure out alternative solution with more time for packed varyings. It is one of the CTS tests that will fail with revert and nothing else gets hurt since it's a corner-case with SSO. I think cur

[Mesa-dev] [PATCH] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-09-28 Thread Tapani Pälli
Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resource list. We need to take this to account with all functions dealing with active input attributes. Patch fixes the issue by adding additional check to is_active_attrib and iterating active attribs explici