Re: [Mesa-dev] [PATCH] mesa: fix glGetInteger/Float/etc queries for vertex arrays attribs

2018-05-10 Thread Jordan Justen
On 2018-05-09 18:51:04, Brian Paul wrote: > The vertex array Size and Stride attributes are now ubyte and short, > respectively. The glGet code needed to be updated to handle those > types, but wasn't. > > Fixes the new piglit test gl-1.5-get-array-attribs test. > > Bugzilla: https://bugs.freede

Re: [Mesa-dev] [PATCH] mesa: fix glGetInteger/Float/etc queries for vertex arrays attribs

2018-05-09 Thread Mathias Fröhlich
Hi Brian, One nit if you want below. Either way: Reviewed-by: Mathias Fröhlich best Mathias On Thursday, 10 May 2018 03:51:04 CEST Brian Paul wrote: [...] > diff --git a/src/mesa/main/get_hash_params.py > b/src/mesa/main/get_hash_params.py > index de5fed6..755d33a 100644 > --- a/src/mesa/main

[Mesa-dev] [PATCH] mesa: fix glGetInteger/Float/etc queries for vertex arrays attribs

2018-05-09 Thread Brian Paul
The vertex array Size and Stride attributes are now ubyte and short, respectively. The glGet code needed to be updated to handle those types, but wasn't. Fixes the new piglit test gl-1.5-get-array-attribs test. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106450 Fixes: d5f42f96e16 ("me