Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-25 Thread Dylan Baker
Quoting Mike Lothian (2018-04-24 18:49:10) > Can you also add radeon to the amd one? That works on autotools > > On Wed, 25 Apr 2018 at 02:16 Jordan Justen wrote: > > Fixes: 5608d0a2cee "meson: use array type options" > Cc: Dylan Baker >

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Jordan Justen
On 2018-04-24 22:31:23, Bas Nieuwenhuizen wrote: > On Wed, Apr 25, 2018 at 6:38 AM, Jordan Justen > wrote: > > On 2018-04-24 18:49:10, Mike Lothian wrote: > >> Can you also add radeon to the amd one? That works on autotools > > > > There is already a

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Bas Nieuwenhuizen
On Wed, Apr 25, 2018 at 6:38 AM, Jordan Justen wrote: > On 2018-04-24 18:49:10, Mike Lothian wrote: >> Can you also add radeon to the amd one? That works on autotools > > There is already a with_gallium_radeonsi flag. Is that what you mean? I'm guessing that he means

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 25.04.2018 04:16, Jordan Justen wrote: Fixes: 5608d0a2cee "meson: use array type options" Cc: Dylan Baker Signed-off-by: Jordan Justen --- meson.build | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Jordan Justen
On 2018-04-24 18:49:10, Mike Lothian wrote: > Can you also add radeon to the amd one? That works on autotools There is already a with_gallium_radeonsi flag. Is that what you mean? This is just a patch to fix the vulkan variables after 5608d0a2cee. Without this change, setting

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Mike Lothian
Can you also add radeon to the amd one? That works on autotools On Wed, 25 Apr 2018 at 02:16 Jordan Justen wrote: > Fixes: 5608d0a2cee "meson: use array type options" > Cc: Dylan Baker > Signed-off-by: Jordan Justen >

[Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Jordan Justen
Fixes: 5608d0a2cee "meson: use array type options" Cc: Dylan Baker Signed-off-by: Jordan Justen --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 52a1075823f..c0e5c94d794 100644