Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-29 Thread Dylan Baker
This should be nominated for stable Quoting Dylan Baker (2018-03-12 11:23:23) > Meson's compiler.has_header is completely useless, it only checks that a > header exists, not whether it's usable. This creates problems if a > header contains a conditional #error declaration, like so: > > > #if

Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-13 Thread Eric Engestrom
On Monday, 2018-03-12 11:23:23 -0700, Dylan Baker wrote: > Meson's compiler.has_header is completely useless, it only checks that a > header exists, not whether it's usable. This creates problems if a > header contains a conditional #error declaration, like so: > > > #if __x86_64__ > > # error

Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-12 Thread Matt Turner
Acked-by: Matt Turner Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-12 Thread Dylan Baker
Meson's compiler.has_header is completely useless, it only checks that a header exists, not whether it's usable. This creates problems if a header contains a conditional #error declaration, like so: > #if __x86_64__ > # error "Doesn't work with x86_64!" > #endif Compiler.has_header will return