Re: [Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2017-01-12 Thread Jason Ekstrand
On Thu, Jan 12, 2017 at 12:38 PM, Matt Turner wrote: > On Thu, Dec 1, 2016 at 1:51 PM, Jason Ekstrand > wrote: > > This fixes a bug in code motion that occurred when the best block is the > > same as the schedule early block. In this case, because

Re: [Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2017-01-12 Thread Matt Turner
On Thu, Dec 1, 2016 at 1:51 PM, Jason Ekstrand wrote: > This fixes a bug in code motion that occurred when the best block is the > same as the schedule early block. In this case, because we're checking > (lca != def->parent_instr->block) at the top of the loop, we never get

[Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2016-12-01 Thread Jason Ekstrand
This fixes a bug in code motion that occurred when the best block is the same as the schedule early block. In this case, because we're checking (lca != def->parent_instr->block) at the top of the loop, we never get to the check for loop depth so we wouldn't move it out of the loop. This commit