Re: [Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

2017-10-28 Thread Eric Anholt
Jason Ekstrand writes: > On October 27, 2017 18:21:45 Matt Turner wrote: > >> ... as can happen with various types like mat4, or else we'll smash the >> stack writing past the end of components_local[]. > > Ugh... Ideally, I think you'd want

Re: [Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

2017-10-27 Thread Jason Ekstrand
On October 27, 2017 18:21:45 Matt Turner wrote: ... as can happen with various types like mat4, or else we'll smash the stack writing past the end of components_local[]. Ugh... Ideally, I think you'd want without_matrix() because a matrix is just an array as far as

[Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

2017-10-27 Thread Matt Turner
... as can happen with various types like mat4, or else we'll smash the stack writing past the end of components_local[]. Fixes: 5a0d3e1129b7 ("nir: Print the components referenced for split or packed shader in/outs.") --- Reproduce with INTEL_DEBUG=vs and