Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-05-02 Thread Alyssa Rosenzweig
> That all sounds good. Those are exactly the things we wanted when > creating NIR, so it's nice to hear :) Hooray! > It might be beneficial for you to lower b2f there Ah, I had not noticed that section was seperate. Yes, I think you're right about that. Updated patch sent. (I hope I did this r

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-05-01 Thread Matt Turner
On Mon, Apr 30, 2018 at 7:50 PM, Alyssa Rosenzweig wrote: >> Tell me a little more about what your hardware supports. > > Both integers and floats are first-class; they are each natively 32-bit, > with 16-bit versions to be supported down the line. There's support for > int8 and float64, but I hav

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-05-01 Thread Alyssa Rosenzweig
> Tell me a little more about what your hardware supports. Both integers and floats are first-class; they are each natively 32-bit, with 16-bit versions to be supported down the line. There's support for int8 and float64, but I haven't seen these used with GLSL, so I don't know how they work. Fr

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-04-30 Thread Matt Turner
On Sun, Apr 29, 2018 at 11:19 AM, Alyssa Rosenzweig wrote: > This pass is required by the Midgard compiler; our instruction set uses > NIR-style booleans (~0 for true) but lacks a dedicated b2f instruction. > Normally, this lowering pass would be implemented in a backend-specific > algebraic pass,

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-04-30 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sun, Apr 29, 2018 at 8:19 PM, Alyssa Rosenzweig wrote: > This pass is required by the Midgard compiler; our instruction set uses > NIR-style booleans (~0 for true) but lacks a dedicated b2f instruction. > Normally, this lowering pass would be implemented in a ba

[Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-04-30 Thread Alyssa Rosenzweig
This pass is required by the Midgard compiler; our instruction set uses NIR-style booleans (~0 for true) but lacks a dedicated b2f instruction. Normally, this lowering pass would be implemented in a backend-specific algebraic pass, but this conflicts with the existing iand->b2f pass in nir_opt_alge