Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Ilia Mirkin
I wouldn't object to it being in stable, but it's also not super-important. It does fix some piglits for freedreno though. (I don't think vc4 exposes GL 3.0, so the problematic condition can't happen there.) On Mon, Jul 10, 2017 at 1:30 PM, Andres Gomez wrote: > Ilia, would we want this patch in

Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Andres Gomez
Ilia, would we want this patch in -stable ? On Fri, 2017-07-07 at 20:34 -0400, Ilia Mirkin wrote: > Fixes a bunch of gl_BackColor interpolation tests that had explicit > interpolation specified on the fragment shader gl_Color. > > Signed-off-by: Ilia Mirkin > --- > src/compiler/nir/nir_lower_tw

Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-08 Thread Rob Clark
On Fri, Jul 7, 2017 at 8:34 PM, Ilia Mirkin wrote: > Fixes a bunch of gl_BackColor interpolation tests that had explicit > interpolation specified on the fragment shader gl_Color. > > Signed-off-by: Ilia Mirkin (as mentioned on irc, but repeated here for posterity) Reviewed-by: Rob Clark > --

[Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-07 Thread Ilia Mirkin
Fixes a bunch of gl_BackColor interpolation tests that had explicit interpolation specified on the fragment shader gl_Color. Signed-off-by: Ilia Mirkin --- src/compiler/nir/nir_lower_two_sided_color.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/ni