Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Samuel Pitoiset
On 03/09/2016 11:27 PM, Samuel Pitoiset wrote: On 03/09/2016 09:28 PM, Vinson Lee wrote: On Wed, Mar 9, 2016 at 5:25 AM, Samuel Pitoiset wrote: On 03/09/2016 01:46 PM, Pierre Moreau wrote: I did hit that issue as well, but I have C++11 forced on my SPIR-V

Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Samuel Pitoiset
On 03/09/2016 09:28 PM, Vinson Lee wrote: On Wed, Mar 9, 2016 at 5:25 AM, Samuel Pitoiset wrote: On 03/09/2016 01:46 PM, Pierre Moreau wrote: I did hit that issue as well, but I have C++11 forced on my SPIR-V branch. I guess adding the whitespace will still

Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Vinson Lee
On Wed, Mar 9, 2016 at 5:25 AM, Samuel Pitoiset wrote: > > > On 03/09/2016 01:46 PM, Pierre Moreau wrote: >> >> I did hit that issue as well, but I have C++11 forced on my SPIR-V branch. >> >> I guess adding the whitespace will still result in code that works with >>

Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Samuel Pitoiset
On 03/09/2016 01:46 PM, Pierre Moreau wrote: I did hit that issue as well, but I have C++11 forced on my SPIR-V branch. I guess adding the whitespace will still result in code that works with older C++ version, so the fix can still be accepted even if we do not plan to switch to C++11 by

Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Pierre Moreau
I did hit that issue as well, but I have C++11 forced on my SPIR-V branch. I guess adding the whitespace will still result in code that works with older C++ version, so the fix can still be accepted even if we do not plan to switch to C++11 by default. Pierre On 11:16 AM - Mar 09 2016, Samuel

Re: [Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Samuel Pitoiset
Nouveau doesn't use c++11 except the codegen part. How do you hit that issue? Pretty sure that you forced c++11, right? I can't reproduce that compilation error with clang 3.9 btw. On 03/09/2016 09:57 AM, Vinson Lee wrote: CXX codegen/nv50_ir.lo In file included from

[Mesa-dev] [PATCH] nouveau: Fix clang reserved-user-defined-literal error.

2016-03-09 Thread Vinson Lee
CXX codegen/nv50_ir.lo In file included from codegen/nv50_ir.cpp:28: ./nouveau_debug.h:19:30: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] fprintf(stderr, "%s:%d - "fmt, __FUNCTION__, __LINE__, ##args)