Re: [Mesa-dev] [PATCH] nv50/ir: Properly fold constants in SPLIT operation

I think we never split values that are < 64-bit wide, as the RA pass does not support < 32-bit wide values. And 64-bit values aren’t used that often, I would guess. Does adding the Fixes: tag here work, or should I send a new version? Fixes: b7d9677d ("nv50/ir: constant fold OP_SPLIT") On 02:46

Re: [Mesa-dev] [PATCH] nv50/ir: Properly fold constants in SPLIT operation

Wait, this is actively buggy! How did this ever work :( I guess we don't split immediates too frequently, and I was testing it with zero's or something. Can you figure out the commit where I added this idiotic code and add a Fixes: tag? Reviewed-by: Ilia Mirkin Cc:

[Mesa-dev] [PATCH] nv50/ir: Properly fold constants in SPLIT operation

Signed-off-by: Pierre Moreau --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp