[Mesa-dev] [PATCH] nv50: make sure to clear _all_ layers of all attachments

2014-02-13 Thread Ilia Mirkin
Unfortunately there's only one RT_ARRAY_MODE setting for all attachments, so clears were previously truncated to the minimum number of layers any attachment had. Instead set the RT_ARRAY_MODE to 512 (the max number of layers) before doing the clear. This fixes

Re: [Mesa-dev] [PATCH] nv50: make sure to clear _all_ layers of all attachments

2014-02-13 Thread Emil Velikov
On 13/02/14 10:13, Ilia Mirkin wrote: Unfortunately there's only one RT_ARRAY_MODE setting for all attachments, so clears were previously truncated to the minimum number of layers any attachment had. Instead set the RT_ARRAY_MODE to 512 (the max number of layers) before doing the clear. This

Re: [Mesa-dev] [PATCH] nv50: make sure to clear _all_ layers of all attachments

2014-02-13 Thread Ilia Mirkin
On Thu, Feb 13, 2014 at 9:57 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 13/02/14 10:13, Ilia Mirkin wrote: Unfortunately there's only one RT_ARRAY_MODE setting for all attachments, so clears were previously truncated to the minimum number of layers any attachment had. Instead set the

Re: [Mesa-dev] [PATCH] nv50: make sure to clear _all_ layers of all attachments

2014-02-13 Thread Roland Scheidegger
Hmm that reminds me when I implemented layered rendering in llvmpipe I figured we'd only need to store the min amount of layers, because rendering is undefined if the index is higher anyway. But of course I didn't think about clears so we can't do that now correctly. Ah well if anyone would really

Re: [Mesa-dev] [PATCH] nv50: make sure to clear _all_ layers of all attachments

2014-02-13 Thread Emil Velikov
On 13/02/14 16:14, Ilia Mirkin wrote: On Thu, Feb 13, 2014 at 9:57 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 13/02/14 10:13, Ilia Mirkin wrote: Unfortunately there's only one RT_ARRAY_MODE setting for all attachments, so clears were previously truncated to the minimum number of