Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Rohan Garg
On Thursday, 20 June 2019 20:20:38 CEST Alyssa Rosenzweig wrote: > This is a rather complex change, adding a lot of code but ideally > cleaning up quite a bit as we go. > > Within a batch (single frame), there are multiple distinct Mali job > types: SET_VALUE, VERTEX, TILER, FRAGMENT for the few

Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Tomeu Vizoso
On 6/21/19 3:05 PM, Alyssa Rosenzweig wrote: Very nice, this will fix a few tests. Ah, of course :) Good riddance! To be fair, a lot of that just got moved in with panfrost_job.. :) Can we remove now the has_draws arg? Maybe? The has_draws arg controls a lot of things beyond just,

Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Alyssa Rosenzweig
> Very nice, this will fix a few tests. Ah, of course :) > Good riddance! To be fair, a lot of that just got moved in with panfrost_job.. :) > Can we remove now the has_draws arg? Maybe? The has_draws arg controls a lot of things beyond just, you know, having draws. The whole API there

Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Tomeu Vizoso
On 6/20/19 8:20 PM, Alyssa Rosenzweig wrote: This is a rather complex change, adding a lot of code but ideally cleaning up quite a bit as we go. Within a batch (single frame), there are multiple distinct Mali job types: SET_VALUE, VERTEX, TILER, FRAGMENT for the few that we emit right now

[Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-20 Thread Alyssa Rosenzweig
This is a rather complex change, adding a lot of code but ideally cleaning up quite a bit as we go. Within a batch (single frame), there are multiple distinct Mali job types: SET_VALUE, VERTEX, TILER, FRAGMENT for the few that we emit right now (eventually more for compute and geometry shaders).