Re: [Mesa-dev] [PATCH] r600/sb: insert the else clause when we might depart from a loop

Makes sense to me, albeit I don't really quite understand sb... Reviewed-by: Roland Scheidegger Am 30.01.2018 um 07:40 schrieb Dave Airlie: > From: Dave Airlie > > If there is a break inside the else clause and this means we > are breaking from a loop, the loop finalise will want to insert > th

Re: [Mesa-dev] [PATCH] r600/sb: insert the else clause when we might depart from a loop

Great job, this fixes the piglit, shows no regressions there, and doesn't add an else branch when it is optimized away. You might want to add that this fixes shaders@ssa@fs-if-def-else-break and Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101442 Since the other piglits that fail with

[Mesa-dev] [PATCH] r600/sb: insert the else clause when we might depart from a loop

From: Dave Airlie If there is a break inside the else clause and this means we are breaking from a loop, the loop finalise will want to insert the LOOP_BREAK/CONTINUE instruction, however if we don't emit the else there is no where for these to end up, so they will end up in the wrong place. Sig