Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Vadim Girlin
On 08/24/2013 07:24 PM, Marek Olšák wrote: See piglit/fbo-alphatest-nocolor. Ah, it seems I just compared wrong results when I was testing all combinations of backends and looked for regressions. Now I think the problem is that even though llvm backend correctly emits color export with nr_c

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Marek Olšák
See piglit/fbo-alphatest-nocolor. Marek On Sat, Aug 24, 2013 at 3:12 PM, Vadim Girlin wrote: > On 08/24/2013 02:31 PM, Marek Olšák wrote: >> >> Like Christoph said, COLOR0 (if available) must always be exported for >> alpha test. > > > Are there any piglit tests for that? I didn't see any regres

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Alex Deucher
On Sat, Aug 24, 2013 at 5:44 AM, Christian König wrote: > Am 24.08.2013 03:30, schrieb Vadim Girlin: > >> Currently llvm backend always exports at least one color in pixel >> shader even if no color buffers are enabled. With depth/stencil exports >> this can result in the following code: >> >> EXP

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Vadim Girlin
On 08/24/2013 02:31 PM, Marek Olšák wrote: Like Christoph said, COLOR0 (if available) must always be exported for alpha test. Are there any piglit tests for that? I didn't see any regressions with this patch (at least on evergreen), possibly I messed up the testing somehow. Also I think old b

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Marek Olšák
Like Christoph said, COLOR0 (if available) must always be exported for alpha test. Marek On Sat, Aug 24, 2013 at 3:30 AM, Vadim Girlin wrote: > Currently llvm backend always exports at least one color in pixel > shader even if no color buffers are enabled. With depth/stencil exports > this can r

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Christoph Bumiller
On 24.08.2013 11:44, Christian König wrote: > Am 24.08.2013 03:30, schrieb Vadim Girlin: >> Currently llvm backend always exports at least one color in pixel >> shader even if no color buffers are enabled. With depth/stencil exports >> this can result in the following code: >> >> EXPORT

Re: [Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-24 Thread Christian König
Am 24.08.2013 03:30, schrieb Vadim Girlin: Currently llvm backend always exports at least one color in pixel shader even if no color buffers are enabled. With depth/stencil exports this can result in the following code: EXPORT PIXEL 0 R0.xyzw VPM EXPORT PIXEL 61R

[Mesa-dev] [PATCH] r600g/llvm: don't export more colors than the number of CBs

2013-08-23 Thread Vadim Girlin
Currently llvm backend always exports at least one color in pixel shader even if no color buffers are enabled. With depth/stencil exports this can result in the following code: EXPORT PIXEL 0 R0.xyzw VPM EXPORT PIXEL 61R1.x___ VPM EXPORT_DONEPIXEL 61R0