Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 6, 2016 at 9:06 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-07 Thread Nicolai Hähnle
On 07.12.2016 04:47, Michel Dänzer wrote: On 07/12/16 05:06 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle The spec actually says that calling EmitStreamVertex is undefined when you exceed max_vertices. But we do need to avoid trampling over memory outside the GSVS

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Michel Dänzer
On 07/12/16 05:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to avoid trampling over memory > outside the GSVS ring. Why "but"? It still works up

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/07/2016 07:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to avoid trampling

[Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Nicolai Hähnle
From: Nicolai Hähnle The spec actually says that calling EmitStreamVertex is undefined when you exceed max_vertices. But we do need to avoid trampling over memory outside the GSVS ring. Cc: mesa-sta...@lists.freedesktop.org -- One more thing I noticed on top of all the