Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-22 Thread Samuel Pitoiset
On 06/22/2017 01:54 AM, Marek Olšák wrote: On Tue, Jun 20, 2017 at 10:56 PM, Samuel Pitoiset wrote: On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading issue because it crashes diffe

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-21 Thread Marek Olšák
On Tue, Jun 20, 2017 at 10:56 PM, Samuel Pitoiset wrote: > > > On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: >> >> I have just tested this patch with Hero Siege, it still crashes. >> >> As you said, it's definitely a multithreading issue because it crashes >> differently all the time. >> >> Let m

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-20 Thread Samuel Pitoiset
On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading issue because it crashes differently all the time. Let me know if you need more information. FWIW, "Peace, Death!" and "Riptale" [1

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-20 Thread Samuel Pitoiset
I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading issue because it crashes differently all the time. Let me know if you need more information. On 06/19/2017 01:40 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle si_build_shader_var

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 19, 2017 at 1:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > si_build_shader_variant can actually be called directly from one of > normal-priority compiler threads. In that case, the thread_index is > only valid for the normal tm array. > > v

[Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-19 Thread Nicolai Hähnle
From: Nicolai Hähnle si_build_shader_variant can actually be called directly from one of normal-priority compiler threads. In that case, the thread_index is only valid for the normal tm array. v2: - use the correct sel/shader->compiler_ctx_state Bugzilla: https://bugs.freedesktop.org/show_bug.c

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-13 Thread Marek Olšák
On Mon, Jun 12, 2017 at 11:26 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > si_build_shader_variant can actually be called directly from one of > normal-priority compiler threads. In that case, the thread_index is > only valid for the normal tm array. > > Bugzilla: https://bugs.freedesktop

[Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

2017-06-12 Thread Nicolai Hähnle
From: Nicolai Hähnle si_build_shader_variant can actually be called directly from one of normal-priority compiler threads. In that case, the thread_index is only valid for the normal tm array. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101384 (maybe) Fixes: 86cc8097266c ("radeonsi: u