Re: [Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

2017-10-23 Thread Alex Smith
On 21 October 2017 at 02:54, Bas Nieuwenhuizen wrote: > For radv_create_shader_variants_from_pipeline_cache I'm not really > sure why this would cause corruption. Yes we might create the variants > a few times too much, but that should not cause any corruption. > Just

Re: [Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

2017-10-20 Thread Bas Nieuwenhuizen
For radv_create_shader_variants_from_pipeline_cache I'm not really sure why this would cause corruption. Yes we might create the variants a few times too much, but that should not cause any corruption. Either way, it is a fix, so Reviewed-by: Bas Nieuwenhuizen and

[Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

2017-10-19 Thread Alex Smith
Need to lock around the whole process of retrieving cached shaders, and around GetPipelineCacheData. This fixes GPU hangs observed when creating multiple pipelines in parallel, which appeared to be due to invalid shader code being pulled from the cache. Signed-off-by: Alex Smith