Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

2018-03-09 Thread Bas Nieuwenhuizen
Sorry, for the delay, I just sent a patch that makes the limits 16 + 8. Going forward it might be an idea to just make this a dynamically sized array and seriously increase the limits. On Fri, Mar 9, 2018 at 5:15 PM, Alex Smith wrote: > Ping. > > Maybe it'd be

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

2018-03-09 Thread Alex Smith
Ping. Maybe it'd be better to just increase MAX_DYNAMIC_BUFFERS? I can't see any side effects of that other than increasing the size of radv_cmd_buffer? Alex On 5 March 2018 at 09:59, Alex Smith wrote: > I just checked what Rise of the Tomb Raider is using.

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

2018-03-05 Thread Alex Smith
I just checked what Rise of the Tomb Raider is using. Maximum it hits for uniform buffers is 15, and 6 for storage buffers. The highest combined total is 15. Alex On 2 March 2018 at 20:11, Bas Nieuwenhuizen wrote: > Hi Alex, > > How many do you need of either type? >

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

2018-03-02 Thread Bas Nieuwenhuizen
Hi Alex, How many do you need of either type? - Bas On Fri, Mar 2, 2018 at 4:28 PM, Alex Smith wrote: > These were set to MAX_DYNAMIC_BUFFERS / 2, which is too restrictive > since an app may have it's total usage of both uniform and storage > within

[Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

2018-03-02 Thread Alex Smith
These were set to MAX_DYNAMIC_BUFFERS / 2, which is too restrictive since an app may have it's total usage of both uniform and storage within MAX_DYNAMIC_BUFFERS, but exceed the limit for one of the types. Recently the validation layers have started raising errors for when these limits are