Re: [Mesa-dev] [PATCH] radv: always free nir shaders from modules on stack

2017-05-05 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, May 2, 2017 at 10:05 PM, Grazvydas Ignotas wrote: > valgrind reports them as leaked, and I could not find anything making a > copy of the nir pointer. Also, radv_device_init_meta_blit_color() is > already freeing them unconditionally like this. > > Signed-o

[Mesa-dev] [PATCH] radv: always free nir shaders from modules on stack

2017-05-02 Thread Grazvydas Ignotas
valgrind reports them as leaked, and I could not find anything making a copy of the nir pointer. Also, radv_device_init_meta_blit_color() is already freeing them unconditionally like this. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_meta_blit.c | 6 ++ src/amd/vulkan/radv_query.