Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-26 Thread Samuel Pitoiset
On 04/25/2018 11:25 AM, Alex Smith wrote: Any more thoughts on this? Any objections to it going to stable as well (it fixes bugs, but is quite a large change)? I will take care of this after running CTS on Polaris/Vega. Thanks, Alex On 19 April 2018 at 09:27, Matthew Nicholls mailto:mnic

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-25 Thread Alex Smith
Any more thoughts on this? Any objections to it going to stable as well (it fixes bugs, but is quite a large change)? Thanks, Alex On 19 April 2018 at 09:27, Matthew Nicholls wrote: > On 18/04/18 22:56, Dave Airlie wrote: > > On 18 April 2018 at 00:31, Matthew Nicholls >> wrote: >> >>> Previou

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-19 Thread Matthew Nicholls
On 18/04/18 22:56, Dave Airlie wrote: On 18 April 2018 at 00:31, Matthew Nicholls wrote: Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample image cop

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-19 Thread Samuel Pitoiset
On 04/18/2018 11:56 PM, Dave Airlie wrote: On 18 April 2018 at 00:31, Matthew Nicholls wrote: Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample ima

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-18 Thread Dave Airlie
On 18 April 2018 at 00:31, Matthew Nicholls wrote: > Previously before fb077b0728, the LOD parameter was being used in place of the > sample index, which would only copy the first sample to all samples in the > destination image. After that multisample image copies wouldn't copy anything > from my

[Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-17 Thread Matthew Nicholls
Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample image copies wouldn't copy anything from my observations. Fix this properly by copying each sample in