Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Eric Engestrom
On Thu, Jun 16, 2016 at 11:15:55AM -0600, Brian Paul wrote: > To match what's done in the automake build. > > v2: Use git rev-parse to get a 10-character hash ID > Fix Python imports > --- Perfect, thanks! Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Jose Fonseca
On 16/06/16 18:15, Brian Paul wrote: To match what's done in the automake build. v2: Use git rev-parse to get a 10-character hash ID Fix Python imports --- src/SConscript | 49 - src/mesa/SConscript | 45

[Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
To match what's done in the automake build. v2: Use git rev-parse to get a 10-character hash ID Fix Python imports --- src/SConscript | 49 - src/mesa/SConscript | 45 ++--- 2 files changed, 50

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
On 06/16/2016 10:31 AM, Eric Engestrom wrote: On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote: On 06/16/2016 07:35 AM, Eric Engestrom wrote: That fixed truncation can give non-unique hashes. Switching to rev-parse (suggested above) fixes this. rev-parse --short produces a 7-char

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Eric Engestrom
On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote: > On 06/16/2016 07:35 AM, Eric Engestrom wrote: > > That fixed truncation can give non-unique hashes. Switching to rev-parse > > (suggested above) fixes this. > > rev-parse --short produces a 7-char hash. No it doesn't, not in the

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
On 06/16/2016 07:35 AM, Eric Engestrom wrote: On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote: To match what's done in the automake build. --- src/SConscript | 43 +++ src/mesa/SConscript | 43 ++-

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Emil Velikov
On 15 June 2016 at 18:58, Brian Paul wrote: > To match what's done in the automake build. Considering the grief that it caused for autoconf builds I've deliberately left scons as-is the moment. There's even one more corner case that I will send a patch out in a moment. -Emil

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Eric Engestrom
On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote: > To match what's done in the automake build. > --- > src/SConscript | 43 +++ > src/mesa/SConscript | 43 ++- > 2 files changed, 45 insertions(+), 41

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Jose Fonseca
On 15/06/16 18:58, Brian Paul wrote: To match what's done in the automake build. --- src/SConscript | 43 +++ src/mesa/SConscript | 43 ++- 2 files changed, 45 insertions(+), 41 deletions(-) diff --git

[Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-15 Thread Brian Paul
To match what's done in the automake build. --- src/SConscript | 43 +++ src/mesa/SConscript | 43 ++- 2 files changed, 45 insertions(+), 41 deletions(-) diff --git a/src/SConscript b/src/SConscript index