Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-11 Thread Timothy Arceri
On Wed, 2016-09-07 at 19:28 +0100, Lionel Landwerlin wrote: > Hi Mark, > > Thanks for the report. > The assumption is that coord will be set on the image by a preceding > SpvOpImageTexelPointer opcode (see top of the > vtn_handle_image function). I don't see how that can be right. The image

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-07 Thread Lionel Landwerlin
Hi Mark, Thanks for the report. The assumption is that coord will be set on the image by a preceding SpvOpImageTexelPointer opcode (see top of the vtn_handle_image function). I don't think there are tests in the CTS exercising this at the moment :( - Lionel On Wed, 2016-09-07 at 10:14 -0700,

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-07 Thread Mark Janes
Hi Lionel, This patch triggered CID 1372521 in Coverity. Please let me know if my the analysis is correct below: Lionel Landwerlin writes: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load >

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Jason Ekstrand
Wow, that was rather annoying... Still, I haven't got much better. Reviewed-by: Jason Ekstrand On Tue, Sep 6, 2016 at 1:44 PM, Lionel Landwerlin wrote: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load >

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store v2: don't handle images like ssbo/ubo (Jason) Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 9:16 AM, Lionel Landwerlin wrote: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load > dEQP-VK.spirv_assembly.instruction.compute.opatomic.store > > Signed-off-by: Lionel Landwerlin >

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 33