Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-23 Thread Ian Romanick
On 08/23/2017 11:09 AM, Jason Ekstrand wrote: > On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick > wrote: > > Reviewed-by: Ian Romanick > > > Did you submit a CTS bug? > >

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-23 Thread Matt Turner
On Wed, Aug 23, 2017 at 2:09 PM, Jason Ekstrand wrote: > On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick wrote: >> >> Reviewed-by: Ian Romanick >> >> Did you submit a CTS bug? > > > No, I didn't. It does get some coverage

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-23 Thread Jason Ekstrand
On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick wrote: > Reviewed-by: Ian Romanick > > Did you submit a CTS bug? > No, I didn't. It does get some coverage through the up-and-coming subgroup tests but it should probably have it's own test. That's

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-23 Thread Ian Romanick
Reviewed-by: Ian Romanick Did you submit a CTS bug? On 08/21/2017 10:11 PM, Jason Ekstrand wrote: > I have no idea how this got missed but it's been missing since forever. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/spirv/vtn_variables.c | 5 -

Re: [Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-21 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote: > I have no idea how this got missed but it's been missing since > forever. > > Cc: mesa-sta...@lists.freedesktop.org > --- >  src/compiler/spirv/vtn_variables.c | 5 - >  1

[Mesa-dev] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-08-21 Thread Jason Ekstrand
I have no idea how this got missed but it's been missing since forever. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/spirv/vtn_variables.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c