On Wed, May 2, 2018 at 10:49 AM, Neil Roberts wrote:
> This behaviour was changed in 1e5b09f42f694687ac. The commit message
> for that says it is just a “tidy up” so my assumption is that the
> behaviour change was a mistake. It’s a little hard to decipher looking
> at the
Looks good to me. Thanks for catching this!
Reviewed-by: Jason Ekstrand
Fixes: 1e5b09f42f694687ac "spirv: Tidy some repeated if checks..."
On Wed, May 2, 2018 at 10:49 AM, Neil Roberts wrote:
> This behaviour was changed in 1e5b09f42f694687ac. The
This behaviour was changed in 1e5b09f42f694687ac. The commit message
for that says it is just a “tidy up” so my assumption is that the
behaviour change was a mistake. It’s a little hard to decipher looking
at the diff, but the previous code before that patch was:
if (builtin ==