Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-14 Thread Ian Romanick
On 11/13/2017 10:49 PM, Timothy Arceri wrote: > > > On 14/11/17 13:30, Ian Romanick wrote: >> On 11/10/2017 02:35 AM, Timothy Arceri wrote: >>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h >>> index 6b5c5bbb36..7c357b07ee 100644 >>> --- a/src/mesa/main/mtypes.h >>> +++

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-13 Thread Timothy Arceri
On 14/11/17 13:30, Ian Romanick wrote: On 11/10/2017 02:35 AM, Timothy Arceri wrote: diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6b5c5bbb36..7c357b07ee 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2352,58 +2376,29 @@ struct

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-13 Thread Ian Romanick
On 11/10/2017 02:35 AM, Timothy Arceri wrote: > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index 6b5c5bbb36..7c357b07ee 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mtypes.h > @@ -2352,58 +2376,29 @@ struct gl_fragment_program_state > */ > struct

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-13 Thread Eric Anholt
Miklós Máté writes: > On 12/11/17 00:06, Timothy Arceri wrote: >> On 12/11/17 04:10, Miklós Máté wrote: >>> Hi, >>> >>> this breaks a few things. The patch below gets rid of the assertion >>> failures, but the reference counting needs a proper fix, and swrast >>> draws

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Miklós Máté
On 12/11/17 00:06, Timothy Arceri wrote: On 12/11/17 04:10, Miklós Máté wrote: Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. Thanks for testing :) Is there

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Timothy Arceri
On 12/11/17 04:10, Miklós Máté wrote: Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. Thanks for testing :) Is there something freely available I can test this

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Miklós Máté
Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. MM diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index faf5b7fa28..b71917d7b1 100644 ---

[Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-10 Thread Timothy Arceri
This increases the size of gl_program but in future a union can be used to offset this increase in memory use. Combining the two reduces code and make it easier to follow. Cc: Miklós Máté --- NOTE: compile tested only. src/mesa/drivers/common/driverfuncs.c | 3 -