Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-25 Thread Brian Paul
On 03/23/2019 10:49 AM, Jose Fonseca wrote: Looks good to me. Reviewed-by: Jose Fonseca Though I wonder if this could happen also when not destroying the current context. (Ie, if we need zoombie textures too?) If we're not destroying the thread's current context, this patch temporarily

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-25 Thread Jose Fonseca
On 25/03/2019 14:26, Brian Paul wrote: > On 03/23/2019 10:49 AM, Jose Fonseca wrote: >> Looks good to me. >> >> Reviewed-by: Jose Fonseca >> >> Though I wonder if this could happen also when not destroying the >> current context. (Ie, if we need zoombie textures too?) > > If we're not

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-24 Thread Neha Bhende
Looks good to me. Reviewed-by: Neha Bhende Regards, Neha From: mesa-dev on behalf of Brian Paul Sent: Friday, March 22, 2019 12:51 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende Subject: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-24 Thread Jose Fonseca
Looks good to me. Reviewed-by: Jose Fonseca Though I wonder if this could happen also when not destroying the current context. (Ie, if we need zoombie textures too?) Jose From: Brian Paul Sent: Friday, March 22, 2019 19:51 To: mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-22 Thread Roland Scheidegger
Looks alright to me, it's all quite tricky stuff... Reviewed-by: Roland Scheidegger Am 22.03.19 um 20:51 schrieb Brian Paul: > When we destroy a context, we need to temporarily make that context > the current one for the thread. > > That's because during context tear-down we make many calls to

[Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-22 Thread Brian Paul
When we destroy a context, we need to temporarily make that context the current one for the thread. That's because during context tear-down we make many calls to _mesa_reference_texobj(, NULL). Note there's no context parameter. If the texture's refcount goes to zero and we need to delete it,

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues

2019-03-21 Thread Neha Bhende
Thanks for the fix! Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, March 21, 2019 6:19 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende Subject: [PATCH] st/mesa: fix texture deletion context mix-up issues When we destroy

[Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues

2019-03-21 Thread Brian Paul
When we destroy a context, we need to temporarily make that context the current one for the thread. That's because during context tear-down we make many calls to _mesa_reference_texobj(, NULL). Note there's no context parameter. If the texture's refcount goes to zero and we need to delete it,