Re: [Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

On 03/08/2019 09:53 AM, Roland Scheidegger wrote: Am 07.03.19 um 17:20 schrieb Brian Paul: Move the variant key declarations inside the scope they're used. Use designated initializers instead of memset() calls. I don't think this will always work as intended, since there's non-explicit padding

Re: [Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

Am 07.03.19 um 17:20 schrieb Brian Paul: > Move the variant key declarations inside the scope they're used. > Use designated initializers instead of memset() calls. I don't think this will always work as intended, since there's non-explicit padding bits in the key, and AFAIK even with c11

Re: [Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, March 7, 2019 8:20 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende Subject: [PATCH] st/mesa: move, clean-up shader variant key decls/inits Move the variant key declarations inside

[Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

Move the variant key declarations inside the scope they're used. Use designated initializers instead of memset() calls. --- src/mesa/state_tracker/st_atom_shader.c | 8 src/mesa/state_tracker/st_program.c | 9 +++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git