Re: [Mesa-dev] [PATCH] svga: fix texture swizzle writemasking

2017-07-11 Thread Charmaine Lee
Looks good. Thanks for the quick fix. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, July 11, 2017 2:02 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga:

[Mesa-dev] [PATCH] svga: fix texture swizzle writemasking

2017-07-11 Thread Brian Paul
Commit bfe1e7737a76e3b046 changed how texture swizzles are set up. This exposed a latent bug in the VMware driver: we were ignoring the texture instruction's writemask when applying the 0 and 1 swizzle terms. This wasn't caught by the Piglit texture swizzle test because it only exercises fixed