Re: [Mesa-dev] [PATCH] vbo: fix attr reset

2016-07-06 Thread Rob Clark
On Wed, Jul 6, 2016 at 9:53 AM, Brian Paul wrote: > On 07/05/2016 08:57 PM, Mathias Fröhlich wrote: >> >> On Tuesday, July 05, 2016 15:47:45 Rob Clark wrote: >> >> > In bc4e0c4 (vbo: Use a bitmask to track the active arrays in >> vbo_exec*.) >> >> > we stopped looping over

Re: [Mesa-dev] [PATCH] vbo: fix attr reset

2016-07-06 Thread Brian Paul
On 07/05/2016 08:57 PM, Mathias Fröhlich wrote: On Tuesday, July 05, 2016 15:47:45 Rob Clark wrote: > In bc4e0c4 (vbo: Use a bitmask to track the active arrays in vbo_exec*.) > we stopped looping over all the attributes and resetting all slots. > Which exposed an issue in

Re: [Mesa-dev] [PATCH] vbo: fix attr reset

2016-07-05 Thread Mathias Fröhlich
On Tuesday, July 05, 2016 15:47:45 Rob Clark wrote: > In bc4e0c4 (vbo: Use a bitmask to track the active arrays in vbo_exec*.) > we stopped looping over all the attributes and resetting all slots. > Which exposed an issue in vbo_exec_bind_arrays() for handling GENERIC0 > vs. POS. > > Split out a

[Mesa-dev] [PATCH] vbo: fix attr reset

2016-07-05 Thread Rob Clark
In bc4e0c4 (vbo: Use a bitmask to track the active arrays in vbo_exec*.) we stopped looping over all the attributes and resetting all slots. Which exposed an issue in vbo_exec_bind_arrays() for handling GENERIC0 vs. POS. Split out a helper which can reset a particular slot, so that