Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Pushed with my R-B On Thu, Dec 22, 2016 at 2:03 PM, Arda Coskunses wrote: > Without this check driver crash when application window > closed unexpectedly. > Acked-by: Edward O'Callaghan > --- > src/vulkan/wsi/wsi_common_x11.c | 4 > 1

[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Without this check driver crash when application window closed unexpectedly. Acked-by: Edward O'Callaghan --- src/vulkan/wsi/wsi_common_x11.c | 4 1 file changed, 4 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

On second thought... I'm not sure how this is possible without an app bug or genuine out-of-memory (not likely). We never query any X11 objects other than visuals and those shouldn't be changing out from under us. The only way I can see this happening without out-of-memory is if the app has a

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

I think it's right to return false if wsi_conn is NULL, but I believe there is also an application error here. >From the Vulkan 1.0.37 spec valid usage for vkGetPhysicalDeviceSurfaceSupportKHR, - *connection* must point to a valid X11 *xcb_connection_t*. - *window* must be a valid X11

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Hi, I think it fixed one of the segfaults with closed vkreplay window, but it still segfaults. For details, see backtrace here: https://github.com/LunarG/VulkanTools/issues/124 - Eero On 20.12.2016 05:59, Arda Coskunses wrote: Without this check driver crash when application

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Acked-by: Edward O'Callaghan On 12/20/2016 02:59 PM, Arda Coskunses wrote: > Without this check driver crash when application window > closed unexpectedly. > --- > src/vulkan/wsi/wsi_common_x11.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Without this check driver crash when application window closed unexpectedly. --- src/vulkan/wsi/wsi_common_x11.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 25ba0c1..afb7809 100644 ---