Re: [Mesa-dev] [PATCH (gles3) 07/20] glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)

2013-01-22 Thread Chad Versace
On 01/21/2013 03:40 PM, Matt Turner wrote: Pedantic whitespace comments: I appreciate whitespace pedantry. Seriously. Ill-formatted poetry is annoying to read. Glad to know I'm not alone. I'll fix all the issues you found before committing this patch.

Re: [Mesa-dev] [PATCH (gles3) 07/20] glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)

2013-01-22 Thread Paul Berry
On 21 January 2013 00:49, Chad Versace chad.vers...@linux.intel.com wrote: That is, evaluate constant expressions of the following functions: packSnorm2x16 unpackSnorm2x16 packUnorm2x16 unpackUnorm2x16 packHalf2x16 unpackHalf2x16 v2: Reuse _mesa_pack_float_to_half and its inverse

[Mesa-dev] [PATCH (gles3) 07/20] glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)

2013-01-21 Thread Chad Versace
That is, evaluate constant expressions of the following functions: packSnorm2x16 unpackSnorm2x16 packUnorm2x16 unpackUnorm2x16 packHalf2x16 unpackHalf2x16 v2: Reuse _mesa_pack_float_to_half and its inverse to evaluate pack/unpackHalf2x16 [for idr]. Signed-off-by: Chad Versace

Re: [Mesa-dev] [PATCH (gles3) 07/20] glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)

2013-01-21 Thread Matt Turner
Pedantic whitespace comments: On Mon, Jan 21, 2013 at 12:49 AM, Chad Versace chad.vers...@linux.intel.com wrote: That is, evaluate constant expressions of the following functions: packSnorm2x16 unpackSnorm2x16 packUnorm2x16 unpackUnorm2x16 packHalf2x16 unpackHalf2x16 v2: Reuse