Re: [Mesa-dev] [PATCH (gles3) 20/20] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)

2013-01-23 Thread Paul Berry
On 21 January 2013 00:49, Chad Versace chad.vers...@linux.intel.com wrote: v2: Remove lewd comment [for idr]. Signed-off-by: Chad Versace chad.vers...@linux.intel.com I don't have any comments on this patch beyond what Eric already said. Hopefully I'll be able to give a pretty quick R-b once

[Mesa-dev] [PATCH (gles3) 20/20] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)

2013-01-21 Thread Chad Versace
v2: Remove lewd comment [for idr]. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs.h | 7 ++ .../dri/i965/brw_fs_channel_expressions.cpp| 12

Re: [Mesa-dev] [PATCH (gles3) 20/20] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)

2013-01-21 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: ir-remove(); diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp index 324e665..0ff296c 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp

Re: [Mesa-dev] [PATCH (gles3) 20/20] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)

2013-01-21 Thread Chad Versace
On 01/21/2013 01:18 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: ir-remove(); diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp index 324e665..0ff296c 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp +++

Re: [Mesa-dev] [PATCH (gles3) 20/20] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)

2013-01-21 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: On 01/21/2013 01:18 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: ir-remove(); diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp index 324e665..0ff296c 100644