Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

On Fri, Feb 2, 2018 at 7:55 AM, Gert Wollny wrote: > Am Freitag, den 02.02.2018, 06:56 -0500 schrieb Ilia Mirkin: >> On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny >> wrote: >> > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: >> > > >> > > >> > > Yes, the _GL spec_ says it is an

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am Freitag, den 02.02.2018, 06:56 -0500 schrieb Ilia Mirkin: > On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny > wrote: > > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: > > > > > > > > > Yes, the _GL spec_ says it is an array. > > > But in gallium it can't be. Therefore I thin

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny wrote: > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: >> >> >> Yes, the _GL spec_ says it is an array. >> But in gallium it can't be. Therefore I think it's incorrect if we >> end up with array accesses there (albeit I was too lazy

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: > > > Yes, the _GL spec_ says it is an array. > But in gallium it can't be. Therefore I think it's incorrect if we > end up with array accesses there (albeit I was too lazy to actually > look at the tgsi, but I'm pretty sure it i

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am 02.02.2018 um 07:53 schrieb Gert Wollny: > Am Freitag, den 02.02.2018, 02:13 +0100 schrieb Roland Scheidegger: >> Am 30.01.2018 um 09:21 schrieb Gert Wollny: >>> Although gl_SampleMaskIn is declared as an array in GLSL, it is >>> effectively a 32 bit mask on all hardware supported by mesa, so th

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am Freitag, den 02.02.2018, 02:13 +0100 schrieb Roland Scheidegger: > Am 30.01.2018 um 09:21 schrieb Gert Wollny: > > Although gl_SampleMaskIn is declared as an array in GLSL, it is > > effectively a 32 bit mask on all hardware supported by mesa, so the > > array indexing is ignored (Thanks Glenn K

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Am 30.01.2018 um 09:21 schrieb Gert Wollny: > Although gl_SampleMaskIn is declared as an array in GLSL, it is > effectively a 32 bit mask on all hardware supported by mesa, so the > array indexing is ignored (Thanks Glenn Kennard for the explanation). > > Add a comment that the assert is not made

[Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

Although gl_SampleMaskIn is declared as an array in GLSL, it is effectively a 32 bit mask on all hardware supported by mesa, so the array indexing is ignored (Thanks Glenn Kennard for the explanation). Add a comment that the assert is not made superfluos by the else branch. Corrects: piglit spec@