Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-07 Thread James Xiong
On Sat, 5 May 2018 09:11:28 +0100 Chris Wilson wrote: > Quoting James Xiong (2018-05-05 01:56:01) > > This series align the buffer size up to page instead of a bucket > > size to improve memory allocation efficiency. > > It doesn't though. It still retrieves up to

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-07 Thread Eero Tamminen
Hi, On 05.05.2018 03:56, James Xiong wrote: From: "Xiong, James" With the current implementation, brw_bufmgr may round up a request size to the next bucket size, result in 25% more memory allocated in the worst senario. For example: Request sizeActual size

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-05 Thread Chris Wilson
Quoting James Xiong (2018-05-05 01:56:01) > This series align the buffer size up to page instead of a bucket size > to improve memory allocation efficiency. It doesn't though. It still retrieves up to the bucket size, so with a little cache poisoning (or a series of unfortunate events) it will be

[Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-04 Thread James Xiong
From: "Xiong, James" With the current implementation, brw_bufmgr may round up a request size to the next bucket size, result in 25% more memory allocated in the worst senario. For example: Request sizeActual size 32KB+1Byte 40KB . 8MB+1Byte 10MB . 96MB+1Byte

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-03 Thread Eero Tamminen
Hi, On 02.05.2018 21:19, James Xiong wrote: On Wed, 2 May 2018 14:18:21 +0300 Eero Tamminen wrote: [...] You're missing information on: * On which plaform you did the testing (affects variance) * how many test rounds you ran, and * what is your variance > I ran

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-02 Thread James Xiong
On Wed, 2 May 2018 14:18:21 +0300 Eero Tamminen wrote: > Hi, > > On 02.05.2018 02:25, James Xiong wrote: > > From: "Xiong, James" > > > > With the current implementation, brw_bufmgr may round up a request > > size to the next bucket size,

Re: [Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-02 Thread Eero Tamminen
Hi, On 02.05.2018 02:25, James Xiong wrote: From: "Xiong, James" With the current implementation, brw_bufmgr may round up a request size to the next bucket size, result in 25% more memory allocated in the worst senario. For example: Request sizeActual size

[Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-01 Thread James Xiong
From: "Xiong, James" With the current implementation, brw_bufmgr may round up a request size to the next bucket size, result in 25% more memory allocated in the worst senario. For example: Request sizeActual size 32KB+1Byte 40KB . 8MB+1Byte 10MB . 96MB+1Byte