Re: [Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-28 Thread Dan McCabe
Comments at the end (where they are supposed to be :). On 06/17/2011 05:54 PM, Dan McCabe wrote: There are three changes from the patch set I published on 6/15: 1) Removed IR pointers from AST classes and moved them to glsl_parser_state, 2) Manage the new IR in a stack-like manner to properly

Re: [Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-19 Thread Eric Anholt
On Sat, 18 Jun 2011 09:29:32 +0200, Keith Packard kei...@keithp.com wrote: On Fri, 17 Jun 2011 17:43:14 -0700, Dan McCabe zen3d.li...@gmail.com wrote: break; // implicit exit from loop at end of switch } while (true); Seems like this could just be

Re: [Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-19 Thread Dan McCabe
On 06/19/2011 02:21 PM, Eric Anholt wrote: On Sat, 18 Jun 2011 09:29:32 +0200, Keith Packardkei...@keithp.com wrote: On Fri, 17 Jun 2011 17:43:14 -0700, Dan McCabezen3d.li...@gmail.com wrote: break; // implicit exit from loop at end of switch } while (true); Seems

Re: [Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-18 Thread Keith Packard
On Fri, 17 Jun 2011 17:43:14 -0700, Dan McCabe zen3d.li...@gmail.com wrote: break; // implicit exit from loop at end of switch } while (true); Seems like this could just be } while (false); as I don't see any way the loop could go around more than once. --

[Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-17 Thread Dan McCabe
This patch set adds support for switch statements to the GLSL compiler. We modify the grammar for the compiler with productions for switch statements and case labels, while adding supporting supporting productions not already present. New AST classes are defined to support those productions.