Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-15 Thread Samuel Iglesias Gonsálvez
On 14/11/2018 22:38, Jason Ekstrand wrote: > I just sent one more, "nir/lower_io: Add shared to get_io_offset_src" > that's required for the pass to apply properly to shared vairables. > I have reviewed it too. > Do we have any testing of shared variables with anything other than 32 > bits? 

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Jason Ekstrand
I just sent one more, "nir/lower_io: Add shared to get_io_offset_src" that's required for the pass to apply properly to shared vairables. Do we have any testing of shared variables with anything other than 32 bits? Do we even test 64 bits? I'm begining to think that there are basically zero

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Samuel Iglesias Gonsálvez
Thanks a lot for this work. Patches 1-7 are, Reviewed-by: Samuel Iglesias Gonsálvez I will review patch 8 later, probably tomorrow. Sam On 14/11/2018 00:23, Jason Ekstrand wrote: > In order to properly do all the different kinds of SSBO and SLM writes that > we have in GL and Vulkan, we

[Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-13 Thread Jason Ekstrand
In order to properly do all the different kinds of SSBO and SLM writes that we have in GL and Vulkan, we have to do some lowering. The hardware doesn't have instructions for writing a N-bit vecM with an arbitrary write-mask. Instead, we have byte scattered messages which work on a scalar byte,